Run CI on Modal, upgrade Bitsandbytes #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 85.39% 85.20% -0.20%
==========================================
Files 81 81
Lines 8006 8049 +43
==========================================
+ Hits 6837 6858 +21
- Misses 1169 1191 +22
🚀 New features to boost your workflow:
|
mryab
commented
Mar 15, 2025
Comment on lines
+383
to
+385
| samples_with_tasks = {sample_idx for sample_idx, _ in task_to_indices.values()} | ||
| pending_samples = len(samples_with_tasks) # samples for which we have less than k_min results | ||
| assert pending_samples <= num_samples |
There was a problem hiding this comment.
It's better to recompute the number of pending_samples, as some samples might have 0 tasks (for example, in test_call_many)
dvmazur
requested review from
justheuristic
and removed request for
justheuristic
dvmazur
approved these changes
Mar 15, 2025
justheuristic
approved these changes
Mar 15, 2025
There was a problem hiding this comment.
Appreciate the version updates and a face lift to the tests. LGTM; pending @dvmazur
mryab
added a commit
that referenced
this pull request
Apr 20, 2025
* Run CI on Modal, upgrade Bitsandbytes * Extract the blocksize for quantization into a constant (cherry picked from commit 767afa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the execution of tests from GitHub Actions to Modal, unlocking the option to use GPUs in those tests in the future. Since Modal workers can have multiple CPUs, we can also run tests in parallel, which speeds them up by approximately 4x — from 8 minutes to under 2 minutes.
Also, as multiple tests seem to be unstable, this PR also disables them for the time being or marks them as flaky with
pytest.mark.xfail. This will be fixed in future PRs.Lastly, since the current version of Bitsandbytes is outdated, the PR upgrades it